feat: add scalable venue catalog queries #58
Merged
+298
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andss
previously approved these changes
Oct 22, 2026
There was a problem hiding this comment.
Reviewed the database-side search, filtering, sorting and pagination. The optional arguments preserve compatibility with the current frontend, totalCount covers the complete filtered result, and unrated venues sort last. All 60 backend tests, typecheck and build pass.
Approved for backend merge and deployment, followed by verification on the VM before merging #56.
One follow-up before releasing #56: searching for the Norwegian label “Nattklubb” currently does not match the stored NIGHTCLUB type, so we should support that label and add a regression test.
erikbsa
approved these changes
Oct 23, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
venueswith optional server-side search, venue-type filtering, sorting and paginationvenueTypesso the client can build its filter options from database valuesSearch is case-insensitive across name, area and type. Multiple venue types are combined with OR. Rating sorting places unrated venues last and uses name and ID as stable tie-breakers. SQL values are parameterized, and literal wildcard characters in searches are escaped.
Verification
npm --prefix server run typechecknpm --prefix server run test:data— 60 tests passednpm --prefix server run buildgit diff --checkDeployment order
This backend change must be reviewed, merged and deployed to the VM before frontend PR #56 is merged. All new arguments are optional, so deploying the backend first remains compatible with the current frontend.